[redis] keyspace_hits metrics: 'gauge' → 'rate'
#1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannmh
force-pushed
the
yann/redis-switch-metric-types2
branch
from
98376c5
to
e24291f
Compare
| self.gauge(self.GAUGE_KEYS[k], info[k], tags=tags) | ||
| for k in set(info).intersection(self.RATE_KEYS): | ||
| self.rate(self.RATE_KEYS[k], info[k], tags=tags) | ||
| for info_name, value in info.iteritems(): |
There was a problem hiding this comment.
This refactoring isn't improving the readability IMO :/ we should likely keep the previous version.
Switch `redis.stats.keyspace_*` metrics from gauge to rate type. WARNING: potential backward incompatibility issues. Fix #1887
yannmh
force-pushed
the
yann/redis-switch-metric-types2
branch
from
e24291f
to
2dc0f62
Compare
remh
added a commit
that referenced
this pull request
Sep 15, 2015
[redis] `keyspace_hits` metrics: 'gauge' → 'rate'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or #1890
Switch
redis.stats.keyspace_*metrics from gauge torate type.
WARNING: potential backward incompatibility issues.
Fix #1887