removed the uses of list comprehensions as looping constructs. #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is wasteful.
|
Thanks for your contribution @jamesandariese. In order to help us understanding what your PR is achieving, could you provide us further details please ? |
|
Using list comprehensions solely as a looping construct causes the side effect of a list being allocated and then discarded for no purpose. These should be written as standard loops instead. |
|
👍 this should be avoided. Thanks! |
remh
added a commit
that referenced
this pull request
Sep 23, 2015
…ions removed the uses of list comprehensions as looping constructs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.