[sqlserver] Close database connections #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnLZeller
force-pushed
the
zeller/sqlserver-close
branch
from
1ed7872
to
f3e02d9
Compare
| @@ -190,6 +192,22 @@ def _conn_string(self, instance): | |||
| conn_str += 'Integrated Security=SSPI;' | |||
| return conn_str | |||
|
|
|||
| def _conn_key_to_string(self, conn_key): | |||
There was a problem hiding this comment.
can't we just add that to the _conn_string method? We could change it to _conn_string(self, **kwargs) and get the DB info with either self._get_access_info(instance) or conn_key depending on what's in **kwargs.
If we can avoid duplicating code that would be great!
JohnLZeller
force-pushed
the
zeller/sqlserver-close
branch
from
f3e02d9
to
9f9b607
Compare
|
@hkaj I chose to modify the _conn_string function to explicitly refer to the 2 possibilities instead. Let me know what you think |
|
lgtm |
JohnLZeller
added a commit
that referenced
this pull request
Oct 26, 2015
[sqlserver] Open/Close database connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we leave database connections open it can cause the SQL Server Agent to hang when attempting to stop.