Add the main_tags to the consul service_check tags #2015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsul_datacenter tag in the health checks. This is needed for when you have the same service name in multiple datacenters
|
@talwai can you take a quick pass at this one ? |
|
Is there anything I can do about that CI build failure? It looks like it is an issue with the test structure not with my code. |
|
@mtougeron I get the same sense here. I'm seeing this test failing on a few of the currently open PRs. We'll dig in on our end and see what we can find. |
|
👍 |
|
Thanks @mtougeron !! |
yannmh
added a commit
that referenced
this pull request
Nov 6, 2015
…th-checks Add the main_tags to the consul service_check tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the main_tags to the service_check tags. This will include the consul_datacenter tag in the health checks. This is needed for when you have the same service name in multiple datacenters