[http_check] fixed check for weak ciphers #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truthbk
force-pushed
the
jaime/httpcheck_fix
branch
from
dfd7c19
to
9284c54
Compare
truthbk
force-pushed
the
jaime/httpcheck_fix
branch
from
9284c54
to
b76490d
Compare
Session object has nearly identical request method. Default value for weakcipher is false. Adding debug logging for weak ciphers. Importing datetime differently to urllib3 code. Added Transport adapter for weak cyphers, requests lib sessions required too. Session object has nearly identical request method. Default value for weakcipher is false. Adding debug logging for weak ciphers. Importing datetime differently to urllib3 code. Changing cipherlist for weak ciphers, now it works. Fixing test_http_check.py to contemplate new weakciphers config param. fixing flake8 issue. More flake8 issue. Assuming time is correct and python>=2.6.3 We still need that getattr check in 2.7
truthbk
force-pushed
the
jaime/httpcheck_fix
branch
from
b76490d
to
dad7edb
Compare
|
Thanks @truthbk, let's merge it. |
yannmh
added a commit
that referenced
this pull request
Nov 16, 2015
[http_check] Support weak SSL/TLS ciphers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the WeakCiphersAdapter we still need to check with getattr for the _tunnel_host attribute, we can't assume it's going to be populated automatically by httplib, requests lib, etc.