[http_check] content-matching with unicode support #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice improvement. 👍 for the added tests. One nitpick though, can you squash the commits and reword to comply with our guideline please ? |
truthbk
force-pushed
the
jaime/unicode_fix
branch
from
0a9f030
to
3d0b759
Compare
|
Thanks @yann! Rebased and fixed the comments - I keep forgetting to do so before asking you guys to review it. Let's see if I can make it a habit. :) |
truthbk
added a commit
that referenced
this pull request
Nov 20, 2015
[http_check] content-matching with unicode support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also - AgentCheck messages could be unicode, so changed it there as well.