Add support for forced SNMP data types to help w/ buggy devices #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truthbk
force-pushed
the
jaime/snmp_buggy
branch
2 times, most recently
from
1f66d52
to
4d0db8b
Compare
|
Looks good! 👍 Could you squash your commits into one or two please? |
truthbk
force-pushed
the
jaime/snmp_buggy
branch
from
1f9ee9d
to
4e746e1
Compare
[snmp] adding tests, minor fix to PR. [snmp] with new SNMP network check, we run test twice to collect results. [snmp] log network check exceptions, fix test. [snmpd-test] add a sleep parameter to ensure interval >= 1
truthbk
force-pushed
the
jaime/snmp_buggy
branch
from
4e746e1
to
8e36e58
Compare
truthbk
added a commit
that referenced
this pull request
Feb 9, 2016
Add support for forced SNMP data types to help w/ buggy devices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a minor touch-up to #1331 by @chrissnell - adding tests and raising an exception in the event of a bad
forced_type.PR summary by @chrissnell:
Add support for forced SNMP data types to help w/ buggy devices
Some SNMP-enabled devices return incorrect data types when certain OIDs are queried. The F5 1600LTM load balancer is an example of such a device. This PR allows for the forcing of data types (to 'gauge' or 'counter') in the event of an incorrect response from the remote agent.
It adds a parameter to the metric definition on the YAML, 'forced_type'.
NOTE: The changes in this PR were tested in a back-ported version of this improved snmp check that Datadog provided me. The check patched here is from a newer version of the agent that I don't have any easy way to test right now. The changes are the same between the versions and it should work but I have no way to test.