Added tag parameter for custom MySQL queries #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| total_tags = tags + check['tags'] | ||
| else: | ||
| total_tags = tags | ||
|
|
There was a problem hiding this comment.
you could probably just do it all in a single line:
total_tags = tags + check.get('tags', [])
check.get('tags', []) will return en empty list if there's no tags in check, or checks['tags'] if it is... So it shortens it a bit.
As you said, here it comes down to readability vs space efficiency.
gzysk8
force-pushed
the
Grant/tags_for_custom_MySQL_queries
branch
from
c945cdf
to
a7922f4
Compare
|
|
gzysk8
added a commit
that referenced
this pull request
Feb 1, 2016
…ries Added tag parameter for custom MySQL queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow tags for MySQL custom queries, separate from the global tags applied to the default metrics