[mysql] resilience when InnoDB is not available or disabled. #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -410,7 +410,7 @@ def _collect_metrics(self, host, db, tags, options, queries): | |||
| results = self._get_stats_from_status(db) | |||
| results.update(self._get_stats_from_variables(db)) | |||
|
|
|||
| if self._is_innodb_engine_enabled(db): | |||
| if (not _is_affirmative(options.get('disable_innodb_metrics', False)) and self._is_innodb_engine_enabled(db)): | |||
There was a problem hiding this comment.
let's document the option in the yaml example: https://github.com/DataDog/dd-agent/blob/jaime/innodbfix/conf.d/mysql.yaml.example#L19
|
👍 Apart from my comments! Feel free to squash and merge once they're addressed |
| # | ||
| # NOTE: skip_innodb_metrics should only be used by users with older (unsupported) versions of |
There was a problem hiding this comment.
typo: skip_innodb_metrics -> disable_innodb_metrics :)
truthbk
force-pushed
the
jaime/innodbfix
branch
from
c106201
to
dfb2f73
Compare
[mysql] if the version is too old, the stats will probable be unavailable anyways. [mysql] disable innodb metrics, respond better to unavailable innodb metrics. [mysql] catch NotSupportedError - possible exception when querying older MySQLs. [mysql] adding flag description to yaml, cleaning query.
truthbk
force-pushed
the
jaime/innodbfix
branch
from
dfb2f73
to
4bce354
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.