[mongodb] better metric tagging #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| metrics_tags = ( | ||
| tags + | ||
| [ | ||
| u"cluster:db:{0}".format(st), # Keep for backward compatibilty purpose |
There was a problem hiding this comment.
I think this justifies adding a FIXME 6.0 in the comment, what do you think?
Also, small typo: compatibilty -> compatibility
|
👍 apart from my small comment |
Add replication set name tag, `replset_name` 🏷 to MongoDB metrics.
MongoDB metrics are tagged with two key sets for the database name, i.e. * `cluster:db:$dbname` for `dbStats` metrics. * `db:$dbname` for `top` metrics. For consistency, add a `db:$dbname` tag to `dbStats` metrics. Do not remove the legacy `cluster:db:$dbname` to avoid backward incompatibilities.
yannmh
force-pushed
the
yann/mongodb-replset-name-tag
branch
from
eeb8e4f
to
95dede2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[mongodb]
replset_nametag 🏷Add replication set name tag,
replset_name<U+1F3F7> to MongoDB metrics.[mongodb]
cluster:db:$dbname→db:$dbname🏷MongoDB metrics are tagged with two key sets for the database name, i.e.
cluster:db:$dbnamefordbStatsmetrics.db:$dbnamefortopmetrics.For consistency, add a
db:$dbnametag todbStatsmetrics. Do notremove the legacy
cluster:db:$dbnameto avoid backwardincompatibilities.