[checks] [process] add pagefault stats #2477
Conversation
gmmeyer
force-pushed
the
greg/indeedeng/pagefaultstats
branch
2 times, most recently
from
6636b18
to
65cc916
Compare
|
I cancelled the failed check, it's just two lines of comments and I didn't think it was necessary to run the whole test suite again for two comments. The checks got run in the previous commit and passed. |
| # http://man7.org/linux/man-pages/man5/proc.5.html | ||
| try: | ||
| data = file_to_string('/proc/%s/stat' % pid) | ||
| except: |
There was a problem hiding this comment.
let's avoid the bare exception here, and do except Exception: instead
|
@gmmeyer Added some comments. Could you also squash the commits you authored into one? |
|
Yes I can squash them |
gmmeyer
force-pushed
the
greg/indeedeng/pagefaultstats
branch
from
8878de4
to
021ec81
Compare
|
The failure was activemq. I'm pretty sure it's unrelated. I can run the tests again if you want. |
gmmeyer
force-pushed
the
greg/indeedeng/pagefaultstats
branch
from
021ec81
to
296cbdd
Compare
| @@ -34,6 +34,10 @@ | |||
| 'w_bytes': 'iowrite_bytes', # FIXME: namespace me correctly (6.x) io.w_bytes | |||
| 'ctx_swtch_vol': 'voluntary_ctx_switches', # FIXME: namespace me correctly (6.x), ctx_swt.voluntary | |||
| 'ctx_swtch_invol': 'involuntary_ctx_switches', # FIXME: namespace me correctly (6.x), ctx_swt.involuntary | |||
| 'minflt': 'mem.minflt', | |||
There was a problem hiding this comment.
Wondering if we should keep these names (mem.minflt, mem.cminflt, etc...) as (presently) defined on the manpage - or if we should make them more human readable. Let's check with the team....
gmmeyer
force-pushed
the
greg/indeedeng/pagefaultstats
branch
from
146200a
to
54c07e2
Compare
|
I've addressed all of these issues in the most recent commit. Let me know if there's anything else. 😃 |
|
👍 looks good! |
Mostly from PR #2363.
I fixed the failing test and rebased against master.