Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using dogstatsd directly appears to not use host tags from config #2546

Closed
miketheman opened this issue May 26, 2016 · 2 comments
Closed

Using dogstatsd directly appears to not use host tags from config #2546

miketheman opened this issue May 26, 2016 · 2 comments
Milestone

Comments

@miketheman
Copy link
Contributor

When using the dogstatsd as a standalone process, the tags value in datadog.conf appears to have no impact.

The use case is to have some default tags set in the config file at startup, so any payload flowing through the dogstatsd server decorates the payload with the host tags.

It appears that the logic for applying host tags is in the collector.py only, so it might be simpler to extract the logic to a common method and use it in both places.

@miketheman miketheman changed the title Using dogstatsd directly appears to not use host tags form config Using dogstatsd directly appears to not use host tags from config May 26, 2016
@yannmh yannmh added this to the Triage milestone May 26, 2016
@yannmh
Copy link
Member

yannmh commented May 26, 2016

Thanks @miketheman :)

I am adding a card in our backlog to consider it in an upcoming release. I'll keep you update as we have more information on it.

Yann

@remh
Copy link
Contributor

remh commented May 27, 2016

Thanks Mike! Not sure we want to do that. The host tags set in datadog.conf are passed to datadog as host tags, i.e. they are not applied directly to the metrics. You can just add the host tags directly to your host using the API or by running the collector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants