Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubernetes] add more metrics related to k8s deployments #2722

Closed
onbjerg opened this issue Aug 1, 2016 · 4 comments
Closed

[kubernetes] add more metrics related to k8s deployments #2722

onbjerg opened this issue Aug 1, 2016 · 4 comments

Comments

@onbjerg
Copy link

onbjerg commented Aug 1, 2016

Right now we can only filter based on replication controllers using kube_replication_controller. It is my understanding that ReplicaSet are also included in this.

It would be a lot better if you could filter based on kube_replica_set and/or kube_deployment. Specific metrics for these could prove valuable for monitoring, e.g. the number of pods running for a specific ReplicaSet/Deployment vs. the desired count. All of these values can be extracted from the k8s API.

Another nice addition would be the number of available and unavailable pods. A pod can be running, but not be available. A pod is only available when it's readiness probe succeeds, otherwise it is unavailable. These metrics could be called kubernetes.pods.available and kubernetes.pods.unavailable respectively.

My proposal is to add the following:

  • kubernetes.pods.desired (for ReplicaSet, Deployments and ReplicationControllers)
  • kubernetes.pods.available
  • kubernetes.pods.unavailable
  • kube_replica_set or/and kube_deployment tags

The addition of these metrics and tags would improve the overall experience with the k8s integration.

@onbjerg
Copy link
Author

onbjerg commented Aug 1, 2016

I might work on this if I have time later this week and if the proposal is 👍

@onbjerg
Copy link
Author

onbjerg commented Aug 2, 2016

The deployment statuses can be found in /apis/extensions/v1beta1/deployments.

@jonmoter
Copy link

+1 on kube_deployment tags

@onbjerg
Copy link
Author

onbjerg commented Oct 18, 2016

Waiting for merge #2728

@onbjerg onbjerg closed this as completed Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants