Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression test; can't get tag when the connection's not actually… #2820

Merged
merged 2 commits into from Sep 8, 2016

Conversation

derekwbrown
Copy link
Contributor

What does this PR do?

Fixes unit test that was checking for the new cluster tag on the test to a bad port.

@yannmh yannmh added this to the 5.9.0 milestone Sep 7, 2016
@yannmh
Copy link
Member

yannmh commented Sep 7, 2016

We are not using the same tag set for service checks as a function of the status. This is actually an issue.
For instance, the following monitor would only return OK (best case a NO DATA if set):

elasticsearch.can_connect by {cluster_name}

In short: let's remove this tag from all service checks.

cc @degemer

@yannmh yannmh self-assigned this Sep 7, 2016
Remove `cluster_name` tag from service checks.
@degemer
Copy link
Member

degemer commented Sep 8, 2016

Tests are 💚 , sky is 🔵 , let's merge this!

@yannmh yannmh merged commit 91d500d into master Sep 8, 2016
@yannmh yannmh deleted the db/es_cluster_fixtest branch September 8, 2016 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants