[php_fpm] Include custom tags in service check #3109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jippi, thanks for contributing! The change looks good to me, could you also update the integration test here? https://github.com/DataDog/dd-agent/blob/master/tests/checks/integration/test_php_fpm.py You should only need to add the configured |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Include custom tags in service check
Motivation
Inside a Docker scheduler, using the
ping_urlis bad, since each restart of the process will assign a new unique port to the process, thus marking the old service as gone, even though its in fact running somewhere else successfully.Including own tags to the service, a cluster alert can be created to mitigate this issue :)