[docker_daemon] Report as many cgroup metrics as possible #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one cgroup stat file is missing, still try to report the metrics from the other files. Also, remove the retry logic as it seems to have been made at a time when `find_cgroup_filename_pattern` was used. Since we're trying all the stat files now we are in fact retrying `len(CGROUP_METRICS)` times
olivielpeau
deleted the
olivielpeau/docker-check-cgroup-file-granular-failure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If one cgroup stat file is missing, still try to report the metrics
from the other files. This allows collecting most cgroup metrics on
vanilla Debian 8 systems (where by default the
memorycgroup metricsare not available).
Also, remove the retry logic as it seems to have been made at a time
when
find_cgroup_filename_patternwas used. Since we're tryingall the stat files now it is as if we were retrying
len(CGROUP_METRICS)times.
Testing Guidelines
Tested this with a containerized agent running on a debian 8 (jessie) VM.
Additional Notes
Addresses #2251 (comment)