Dbrown/new windows checks #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add side by side checks for testing statefull winpdh Fix sample time Merge changes back to allow for stateful implementation of pdh, and other fixes Fix invalid list syntax
Add side by side checks for testing statefull winpdh Fix sample time Merge changes back to allow for stateful implementation of pdh, and other fixes Fix invalid list syntax
…nto dbrown/windows-checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note. This is resubmitting #3042. The PR had been sitting out a while, and I had trouble with the merge/rebase. This is the same PR, with review feedback rolled in.
What does this PR do?
Makes the basic system checks use other means besides WMI. The WMI checks are having anecdotal reports of slow checks and other problems. This change removes use of the WMI check (though leaves the WMI checks available, since standalone WMI checks are supported).
Motivation
Support tickets.
Testing Guidelines
Additional Notes
While there are reports of the WMI check failing in unpredictable ways, it's not been reported in-house. Therefore, there's no conclusive proof this checkin is an improvement.