Add container name tag in auto discovery #3421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hush-hush
reviewed
Jul 10, 2017
| @@ -337,8 +338,13 @@ def get_tags(self, state, c_id): | |||
|
|
|||
| return tags | |||
|
|
|||
| def _get_container_name(self, state, c_id, tpl_var): | |||
There was a problem hiding this comment.
tpl_var isn't used at all, is it normal ?
There was a problem hiding this comment.
yeah it's passed to all tag extractors by https://github.com/DataDog/dd-agent/blob/5.14.1/utils/service_discovery/sd_docker_backend.py#L489 but only used by some.
hush-hush
approved these changes
Jul 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
What does this PR do?
Rework #3365 to move back to a different template variable name.
Motivation
This is something we actually don't want included by default in
%%tags%%. It should be used with care as it could flood the tag auto complete menu with a useless tag if used carelessly (typically: in a highly volatile environment where containers churn often and have different names each time).Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Additional Notes
Sorry for the back and forth @subuk, your first version was actually the good one!