add flag to image_name_extractor to return short image name #3622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
JulienBalestra
suggested changes
Jan 8, 2018
| """ | ||
| Returns the image name for a container, either directly from the | ||
| container's Image property or by inspecting the image entity if | ||
| the reference is its sha256 sum and not its name. | ||
| Result is cached for performance, no invalidation planned as image | ||
| churn is low on typical hosts. | ||
| If short is true, the repository is stripped from the result | ||
| """ |
There was a problem hiding this comment.
To avoid reading two times the composition of functions, why not doing something like:
image = self.image_name_resolver(co.get('Image', ''))
if short:
image.split('/')[-1]
return image
JulienBalestra
approved these changes
Jan 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
What does this PR do?
Fix #3082
Motivation
user request
Testing Guidelines
this PR is tied to ... - they should be tested together
Additional Notes
Anything else we should know when reviewing?