Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pup logs are too chatty #414

Closed
conorbranagan opened this issue Mar 19, 2013 · 3 comments
Closed

pup logs are too chatty #414

conorbranagan opened this issue Mar 19, 2013 · 3 comments
Assignees

Comments

@conorbranagan
Copy link
Member

Lots of stuff like this over and over again...

2013-03-19T15:19:41.298197+00:00 10.158.11.230 INFO | dd.pup | root(web.py:1447) | 200 POST /intake?api_key=REDACTED (127.0.0.1) 1.05ms
2013-03-19T15:19:41.423233+00:00 10.28.74.248 INFO | dd.pup | root(web.py:1447) | 200 POST /api/v1/series (127.0.0.1) 1.07ms
2013-03-19T15:19:41.621091+00:00 10.159.54.71 INFO | dd.pup | root(web.py:1447) | 200 POST /intake?api_key=REDACTED (127.0.0.1) 1.68ms
2013-03-19T15:19:41.730281+00:00 10.28.140.103 INFO | dd.pup | root(web.py:1447) | 200 POST /api/v1/series (127.0.0.1) 0.84ms
2013-03-19T15:19:41.809920+00:00 10.73.71.232 INFO | dd.pup | root(web.py:1447) | 200 POST /api/v1/series (127.0.0.1) 3.23ms
2013-03-19T15:19:41.913454+00:00 10.159.19.136 INFO | dd.pup | root(web.py:1447) | 200 POST /intake?api_key=REDACTED (127.0.0.1) 1.45ms
@conorbranagan
Copy link
Member Author

Maybe we can just change the default logging level for pup to warning in the code like we do with the forwarder.

@remh
Copy link
Contributor

remh commented Mar 19, 2013

From tornardo source code:

def log_request(self, handler):
        """Writes a completed HTTP request to the logs.

        By default writes to the python root logger.  To change
        this behavior either subclass Application and override this method,
        or pass a function in the application settings dictionary as
        'log_function'.
        """

We should pass our own logging function instead of changing the root log level.

@remh
Copy link
Contributor

remh commented Mar 19, 2013

@ghost ghost assigned remh Mar 19, 2013
@remh remh closed this as completed in eab54dd Mar 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants