3.7.0 introduced a weird bug that breaks some checks on some configurations

[remh]

It happens when we try to launch a java process (e.g. nodetool, jmxconnector)

Could not reserve enough space for object heap
Could not create the Java virtual machine.

It doesn't happen on all configurations though.

My guess is that it's related to this pull request:
#429

Need to be fixed asap.
ETA of the release: end of this week.

[remh]

Commenting this line:
https://github.com/DataDog/dd-agent/blob/master/util.py#L271

Fixes the issue confirming that it's coming from that pull request.

[remh]

So the solutions are:

1. reverting this feature
2. feature flag it and let the user customize the limits in datadog.conf, should it be enable or disable by default ?

My thoughts would be the solution number 2, disabled by default.

[alq666]

I vote for number 2, disabled by default so that most folks don't even risk a chance to get hit by this.

[remh]

cool that's what i did :)

[remh]

Fixed by f2304b9