Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source agent runs start regardless of command #512

Closed
elijahandrews opened this issue May 21, 2013 · 3 comments
Closed

Source agent runs start regardless of command #512

elijahandrews opened this issue May 21, 2013 · 3 comments
Assignees

Comments

@elijahandrews
Copy link
Contributor

$  bin/agent status
Starting supervisor
2013-05-21 11:47:47,894 INFO RPC interface 'supervisor' initialized
2013-05-21 11:47:47,894 CRIT Server 'unix_http_server' running without any HTTP authentication checking
2013-05-21 11:47:47,895 INFO supervisord started with pid 98048
2013-05-21 11:47:48,897 INFO spawned: 'dogstatsd' with pid 98052
2013-05-21 11:47:48,899 INFO spawned: 'forwarder' with pid 98053
2013-05-21 11:47:48,902 INFO spawned: 'collector' with pid 98054
...

Once you ctrl-c out, it will run the actual command.

I think that lines 7 to 14 of /bin/agent should be moved into the $action case statement, under the start command (currently line 24).

@remh
Copy link
Contributor

remh commented May 21, 2013

if the supervisor is not already running then the agent is not running and the info page will show that it's not running which is useless.

@elijahandrews
Copy link
Contributor Author

So is this intended functionality? This is different from how it works on deb and redhat, where running status will simply tell you if the agent is running. I know that some users would want to use the status command in configuration management tools, so we should try to be consistent across different packaging.

@clutchski
Copy link
Contributor

yes, running "status" shouldn't try to run the program itself (same with info)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants