Implements #945: monitor Redis key lengths #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the 'keys' parameter with a list of key names (e.g. 'testkey') in one Redis instance adds a metric 'redis.key.length' where list lengths are reported using the LLEN command and they are tagged with their names (e.g. tag 'key:testkey').
| @@ -177,6 +177,16 @@ def _check_db(self, instance, custom_tags=None): | |||
| self.rate('redis.net.commands', info['total_commands_processed'], | |||
| tags=tags) | |||
|
|
|||
| # Check some key lengths if asked | |||
| if instance.get('keys') is not None: | |||
There was a problem hiding this comment.
Could you check that it's actually a list ? and maybe raise a warning (using self.warning) if it's not and skip the key length collection ?
|
👍 |
remh
added a commit
that referenced
this pull request
Jun 6, 2014
Implements #945: monitor Redis key lengths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the 'keys' parameter with a list of key names (e.g. 'testkey')
in one Redis instance adds a metric 'redis.key.length' where list
lengths are reported using the LLEN command and they are tagged with
their names (e.g. tag 'key:testkey').