RUMM-671 DatadogObjC target is fixed for SPM #220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
DatadogObjC
wasn't compiling with @objc attribute used without importing module 'Foundation' errorsThis only happens in Swift Package Manager; other dependency managers work fine
For more info: #218
How?
I added
import Foundation
lines to source files.I also made dep-manager-test/spm import
DatadogObjC
instead ofDatadog
, this should test both targets at once.Note: I'm still investigating how come Xcode manages to build the project without those imports 🤔
Release info
This PR is branched off from 1.3.0 tag and to be merged into master
We will ship this change as a hotfix once it is merged
Review checklist