RUMM-700 Environment regex changed #246
Merged
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncreated
requested changes
Sep 10, 2020
| @@ -140,9 +140,9 @@ extension FeaturesConfiguration { | |||
| } | |||
|
|
|||
| private func ifValid(environment: String) throws -> String { | |||
| let regex = #"^[a-zA-Z0-9_]+$"# | |||
| let regex = #"^[a-zA-Z0-9_./-]+$"# | |||
There was a problem hiding this comment.
There are more rules to include in this regexp, i.e. "must start with a letter", "can be up to 200 characters long".
There was a problem hiding this comment.
Ref to Android regexp: DataDog/dd-sdk-android#369 (comment)
buranmert
force-pushed
the
buranmert/RUMM-700-env-validation
branch
from
d38d463
to
0e9eea7
Compare
ncreated
requested changes
Sep 10, 2020
buranmert
force-pushed
the
buranmert/RUMM-700-env-validation
branch
from
0e9eea7
to
4b37e93
Compare
Android's regex is used, which allows "_./-" as non-alphanumerics
buranmert
force-pushed
the
buranmert/RUMM-700-env-validation
branch
from
4b37e93
to
ec457fa
Compare
ncreated
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
There was a discrepancy between Android's environment validation rule and ours.
For instance,
shop.istwas invalid for us whereas it was valid for Android and more importantly valid for RUM Explorer.How?
Now we use Android's regex, which allows "_./-" as non-alphanumerics.
Review checklist