Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUMM-833 Add public API for Data Tracking Consent #335

Merged
merged 4 commits into from Dec 16, 2020
Merged

RUMM-833 Add public API for Data Tracking Consent #335

merged 4 commits into from Dec 16, 2020

Conversation

ncreated
Copy link
Collaborator

@ncreated ncreated commented Dec 8, 2020

What and why?

馃摝 This PR adds the public API for configuring tracking consent:

Datadog.initialize(
   appContext: ...,
   trackingConsent: .pending,
   configuration: ....
)

Datadog.set(trackingConsent: .granted)

How?

New public APIs were introduced both for Datadog and DatadogObjc.

The previous variant of Datadog.initialize() is marked deprecated.

I also added tests for Logger, Tracer and RUMMonitor to assert they respect the consent value when collecting data.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference

@ncreated ncreated requested a review from a team as a code owner December 8, 2020 15:28
@ncreated ncreated self-assigned this Dec 8, 2020
Base automatically changed from ncreated/RUMM-832-add-data-migrators to tracking-consent December 16, 2020 12:43
@ncreated ncreated merged commit a3a3a44 into tracking-consent Dec 16, 2020
@ncreated ncreated deleted the ncreated/RUMM-833-add-tracking-consent-public-API branch December 16, 2020 12:44
@ncreated ncreated mentioned this pull request Dec 16, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buranmert buranmert buranmert approved these changes

Assignees

@ncreated ncreated

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ncreated @buranmert