RUMM-1278 RefreshRate is normalized to 0...60 #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgouchet
approved these changes
Sep 24, 2021
| @@ -39,7 +39,7 @@ class VitalInfoSamplerTests: XCTestCase { | |||
| XCTAssertEqual(sampler.memory.meanValue, 321.0) | |||
| XCTAssertGreaterThan(sampler.memory.sampleCount, 1) | |||
| let maxFPS = Double(UIScreen.main.maximumFramesPerSecond) | |||
| XCTAssertEqual(sampler.refreshRate.meanValue, 666.0 / maxFPS) | |||
There was a problem hiding this comment.
You could have left the 666 value and then used:
XCTAssertEqual(sampler.refreshRate.meanValue, (666.0 / maxFPS) * 60.0)
buranmert
force-pushed
the
buranmert/RUMM-1278-fix-refresh-rate-scale
branch
from
9784a51
to
b1437d5
Compare
ncreated
reviewed
Sep 24, 2021
| @@ -39,7 +39,7 @@ internal final class VitalInfoSampler { | |||
|
|
|||
| var refreshRate: VitalInfo { | |||
| let info = refreshRatePublisher.currentValue | |||
| return info.scaledDown(by: maximumRefreshRate) | |||
| return info.scaledDown(by: maximumRefreshRate / 60.0) | |||
There was a problem hiding this comment.
How about defining a constant and adding a comment on normalization? I'm afraid that this might become forgotten and unclear.
There was a problem hiding this comment.
comment added to the line above
NOTE:
refreshRateis normalized to 0...60 range, assuming 60 is the industry standard.
There was a problem hiding this comment.
I agree with using a constant value for this!
There was a problem hiding this comment.
i can't come up with a local variable name which doesn't make things more confusing 🤔
any suggestions?
There was a problem hiding this comment.
struct Constants {
// We use normalized 0...60 range for refresh rate in Mobile Vitals,
// assuming 60 is the industry standard.
static let normalizedRefreshRate = 60
}Is +/- what we do in other places.
ncreated
pushed a commit
that referenced
this pull request
Oct 4, 2021
…rate-scale RUMM-1278 RefreshRate is normalized to 0...60 (cherry picked from commit 818ed4c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
RefreshRateis shown as a mobile vital in Datadog UI.It needs to be normalized as different devices can have different maximum FPS rates.
How?
It was normalized to 0...1, this was not consistent with other platforms.
Now it is normalized to 0...60 range, as browser and Android SDKs do.
Review checklist