RUMM-1805 Set PLCrashReporter custom path
#692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxep
changed the title
maxep
changed the title
PLCrashReporter custom path
fuzzybinary
approved these changes
Dec 17, 2021
ncreated
requested changes
Dec 20, 2021
There was a problem hiding this comment.
Looks all good 👍.
Integration tests might be failing as we also need to update this path in our persistence helper used to ensure clear state for some integration tests.
|
@ncreated I need further investigation... It doesnt seem to be writing any report in the custom dir 🤔 |
|
I now let PLCR create the subdirectories by just providing the base path (not absolute string as before) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Configure
PLCrashReporterwith a custom storage location to/Library/Caches/com.datadoghq.crash-reporting/v1.By setting a custom path, we allow other instances of
PLCrashReporterto work alongside the SDK without altering the reports.How?
Sets the
basePathproperty of the PLCrashReporterConfig.The
PLCrashReporterversion has been incremented to1.10.1to use the[PLCrashReporter crashReportPath]in tests.Review checklist