RUMM-1796 Crash Reporting Logging #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxep
commented
Jan 10, 2022
maxep
commented
Jan 10, 2022
maxep
force-pushed
the
maxep/RUMM-1796/crash-reporting-user-log
branch
from
2f1cfd6
to
2111e00
Compare
maxep
force-pushed
the
maxep/RUMM-1796/crash-reporting-user-log
branch
from
2111e00
to
3c6e614
Compare
ncreated
requested changes
Jan 12, 2022
Sources/Datadog/FeaturesIntegration/CrashReporting/CrashReportingWithRUMIntegration.swift
Outdated
Show resolved
Hide resolved
Sources/Datadog/FeaturesIntegration/CrashReporting/CrashReportingWithRUMIntegration.swift
Outdated
Show resolved
Hide resolved
maxep
commented
Jan 12, 2022
Sources/DatadogCrashReporting/PLCrashReporterIntegration/CrashReport.swift
Outdated
Show resolved
Hide resolved
maxep
force-pushed
the
maxep/RUMM-1796/crash-reporting-user-log
branch
2 times, most recently
from
a75f971
to
05624b1
Compare
maxep
force-pushed
the
maxep/RUMM-1796/crash-reporting-user-log
branch
from
b9a8a80
to
8e9a82b
Compare
ncreated
reviewed
Jan 14, 2022
There was a problem hiding this comment.
LG 👍 , though what about this from RUMM-1796:
INFOlog determining if the crash report is found after app launch, or if it's missing;
sendCrashReportIfFound() seems a good place for it, no?
Problem was CR's `queue` leaking reference to global `userLogger` and running into threading race conditions on this being replaced by SDK's tear down logic in tests.
ncreated
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Add logs to crash reporting.
How?
Inject user and internal logger to crash reporting plugin.
Review checklist