Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl.cpp leaks CURL handles #31

Closed
dgoffredo opened this issue May 7, 2023 · 0 comments
Closed

curl.cpp leaks CURL handles #31

dgoffredo opened this issue May 7, 2023 · 0 comments

Comments

@dgoffredo
Copy link
Contributor

curl_easy_cleanup is not called on all CURL* objects.

curl_easy_cleanup is called (via CurlLibrary::easy_cleanup) when there's a failure to set up the handle (in post), and when the handle is completed or failed (in handle_message). It is not called for handles that have not completed by the time we're shutting down (at the end of run).

Add a call to curl_.easy_cleanup(handle) after this line:

log_on_error(curl_.multi_remove_handle(multi_handle_, handle));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant