Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNS tracing fail #1120

Closed
bodinsamuel opened this issue Oct 19, 2020 · 2 comments · Fixed by #1128
Closed

DNS tracing fail #1120

bodinsamuel opened this issue Oct 19, 2020 · 2 comments · Fixed by #1128
Labels
bug Something isn't working community integrations
Milestone
0.28.0

Comments

@bodinsamuel
Copy link
Contributor

bodinsamuel commented Oct 19, 2020 •
edited

Describe the bug
When tracing DNS, all dns.lookup call will fail

Environment

  • Operation system: macOS catalina, Kubernetes 1.16
  • Node version: 14.13.1
  • Tracer version: 0.26.1
  • Agent version:

Repro

https://github.com/bodinsamuel/dd-trace-dns-issue
@bodinsamuel bodinsamuel added the bug Something isn't working label Oct 19, 2020
@rochdev
Copy link
Member

rochdev commented Oct 21, 2020

It looks like an issue with promisifying dns methods since Node changes the return value internally because the callback version is not standard. I'm working on a fix but in the meantime I would recommend using the actual promise implementation using dns.promises.lookup() which should work properly.

@bodinsamuel
Copy link
Contributor Author

Thanks for the recommendation, will try 🙏🏻

@rochdev rochdev mentioned this issue Oct 21, 2020
Merged
@rochdev rochdev added this to the 0.28.0 milestone Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working community integrations
Projects
None yet
Milestone
0.28.0
Development

Successfully merging a pull request may close this issue.

fix instrumented functions missing symbols from the original DataDog/dd-trace-js
2 participants
@rochdev @bodinsamuel