Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opentracing API incompability with DataDog agent v5.12.3 #135

Closed
sutris opened this issue Jun 6, 2018 · 1 comment · Fixed by #137
Closed

Opentracing API incompability with DataDog agent v5.12.3 #135

sutris opened this issue Jun 6, 2018 · 1 comment · Fixed by #137
Assignees
Labels
bug Something isn't working community
Milestone

Comments

@sutris
Copy link

sutris commented Jun 6, 2018

Hi,

I noticed that dd-trace v0.2.1's Opentracing API is incompatible with DataDog agent v5.12.3

When the following code is executed:

const tracer = require('dd-trace').init({ service: 'example' });

const span = tracer.startSpan('span_name');
span.setTag('resource.name', '/hello/:name');
span.setTag('span.type', 'web');

span.finish();

the following error is logged in trace-agent.log:

cannot decode v0.3 traces payload: msgp: attempted to decode type "int" with method for "uint"

The current workaround is to use dd-trace v0.1.7

Thank you in advance 🙏

@rochdev
Copy link
Member

rochdev commented Jun 6, 2018

@sutris-sdp This will be fixed in the next release. I don't know how feasible this is for you, but as a temporary workaround you could upgrade the agent to 5.14+ which supports signed integers for IDs. In any case I would recommend keeping the agent up-to-date.

@rochdev rochdev added this to the 0.3.0 milestone Jun 13, 2018
@rochdev rochdev added the bug Something isn't working label Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants