Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http module configuration breaks server APM reporting #2225

Closed
clement-heliot opened this issue Jul 28, 2022 · 6 comments
Closed

http module configuration breaks server APM reporting #2225

clement-heliot opened this issue Jul 28, 2022 · 6 comments
Labels
bug Something isn't working integration-http

Comments

@clement-heliot
Copy link

clement-heliot commented Jul 28, 2022

👋 I have a case where configuring the http module breaks the APM reporting of the server. The service http-client is still being reported correctly.

Expected behaviour
I would expect configuring the http module this way would not break the APM server reporting.

Actual behaviour
APM server reporting is broken and stop reporting.

Steps to reproduce

tracer.use('http', {
    server: {
      blocklist: ['/ping'],
    },
    client: {
      blocklist: [
        'https://back.sqreen.io/sqreen/v1/app-beat',
        'https://ingestion.sqreen.com/batches',
        'https://events.launchdarkly.com/bulk',
      ],
    },
  })

Environment

  • Tracer version: 2.10.0
@rochdev
Copy link
Member

rochdev commented Jul 28, 2022

When you say "stop reporting" do you mean that you're no longer getting traces at all, only when you use a blocklist configuration?

@clement-heliot
Copy link
Author

@rochdev Yep, the APM Service page stopped being updated. Say the service name was saturne, saturne APM page wasn't receiving anything. However saturne-http-client was working as expected. When I rolled back the changes and removed the configuration, saturne APM page worked again.

@rochdev
Copy link
Member

rochdev commented Jul 28, 2022

Is this something you are able to easily isolate in a reproduction snippet? Also, was there anything else in that change, for example changing the version of dd-trace?

@clement-heliot
Copy link
Author

clement-heliot commented Jul 28, 2022

@rochdev Nope, basically I changed

tracer.use('http', { blocklist: ['/ping'] })

to

tracer.use('http', {
  server: {
    blocklist: ['/ping'],
  },
  client: {
    blocklist: [
      'https://back.sqreen.io/sqreen/v1/app-beat',
      'https://ingestion.sqreen.com/batches',
      'https://events.launchdarkly.com/bulk',
    ],
  },
})

Only those changes were made, no dd-trace version change were involved.

@clement-heliot clement-heliot changed the title http module configuration break server APM reporting http module configuration breaks server APM reporting Aug 5, 2022
@tlhunter
Copy link
Member

@clement-heliot can you confirm if you're still facing this issue with a current tracer version?

@tlhunter
Copy link
Member

I'll close this for now but we can reopen it if it's still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working integration-http
Projects
None yet
Development

No branches or pull requests

3 participants