Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for gRPC #311

Closed
rochdev opened this issue Oct 15, 2018 · 4 comments · Fixed by #547
Closed

Add support for gRPC #311

rochdev opened this issue Oct 15, 2018 · 4 comments · Fixed by #547

Comments

@rochdev
Copy link
Member

rochdev commented Oct 15, 2018

Related: #312

@ebenoist
Copy link

I'd be happy to test this out!

@ebenoist
Copy link

I was able to create an interceptor for this!

https://gist.github.com/ebenoist/00c8695e8750138f76ef3f4b97b135a1

@rochdev
Copy link
Member Author

rochdev commented Nov 26, 2018

Thanks for this @ebenoist! I'm not very familiar with gRPC, are interceptors documented somewhere? Also, are they available on the server as well?

@ebenoist
Copy link

ebenoist commented Nov 26, 2018

It depends on the implementation. Client interceptors were added to grpc node core in version 1.11. Server interceptors in node are planned, but not currently implemented AFAIK. I've used the Proxy API in the past to fake this behavior, but it's than ideal.

I used these docs to write the implementation we are currently using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants