Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastify: 404s logged as errors? #629

Closed
danhaller opened this issue Jul 16, 2019 · 0 comments · Fixed by #630
Closed

Fastify: 404s logged as errors? #629

danhaller opened this issue Jul 16, 2019 · 0 comments · Fixed by #630
Labels
bug Something isn't working community integrations
Milestone

Comments

@danhaller
Copy link

danhaller commented Jul 16, 2019

Describe the bug
Hi,

I've just upgraded to 0.13.0 with fastify support and was surprised to see datadog apm showing 404s as errors:

Screenshot from 2019-07-16 16-15-14

Screenshot from 2019-07-16 16-25-35

Screenshot from 2019-07-16 16-56-10

Fastify does create an error object but it goes on to return a response with a 404 status code https://github.com/fastify/fastify/blob/master/lib/fourOhFour.js#L53

Environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community integrations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants