Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message logged for every emitted trace #712

Closed
rdacquisto opened this issue Oct 10, 2019 · 1 comment · Fixed by #722
Closed

Error message logged for every emitted trace #712

rdacquisto opened this issue Oct 10, 2019 · 1 comment · Fixed by #722
Labels
bug Something isn't working community core
Milestone

Comments

@rdacquisto
Copy link

Describe the bug
Every time a trace is emitted, I am seeing a null error in the logs. The cause of this log message is

this._prioritySampler.update(JSON.parse(res).rate_by_service)

this._prioritySampler is undefined. The e from the catch block is

TypeError: Cannot read property 'update' of undefined.

The variable e isn't exposed, and the null err variable is returned. err Cannot have a value and reach

.

Environment

  • Operation system: Linux
  • Node version: 10.15.3
  • Tracer version: 0.15.4 (seen since at least 0.15.1. The stack only recently was made visible.)
  • Agent version: Latest (Installed today)
@rdacquisto rdacquisto added the bug Something isn't working label Oct 10, 2019
@rochdev
Copy link
Member

rochdev commented Oct 22, 2019

The null part was fixed in #716. The actual error will also be fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants