[Bug]: building fails on x86_64-darwin architecture

[drupol]

Bug report

Hi,

I'm opening this issue hoping to find the reason why I'm unable to build datadog_trace 0.89.0 on x86_64-darwin.

I successfully build the extension on the following architecture:

• x86_64-linux
• aarch64-linux
• aarch64-darwin

However, I'm unable to build it on x86_64-darwin, it fails with the following error:

/nix/store/s2ps2rq1k0k7sqw47yc7mi5311y1kqfl-bash-5.2-p15/bin/bash /private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/libtool --mode=compile clang -I. -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/include -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/main -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source -I/nix/store/547rl0b0d6hl9hwxj6dx8r06x8c99y9m-php-8.3.0alpha3-dev/include/php -I/nix/store/547rl0b0d6hl9hwxj6dx8r06x8c99y9m-php-8.3.0alpha3-dev/include/php/main -I/nix/store/547rl0b0d6hl9hwxj6dx8r06x8c99y9m-php-8.3.0alpha3-dev/include/php/TSRM -I/nix/store/547rl0b0d6hl9hwxj6dx8r06x8c99y9m-php-8.3.0alpha3-dev/include/php/Zend -I/nix/store/547rl0b0d6hl9hwxj6dx8r06x8c99y9m-php-8.3.0alpha3-dev/include/php/ext -I/nix/store/547rl0b0d6hl9hwxj6dx8r06x8c99y9m-php-8.3.0alpha3-dev/include/php/ext/date/lib -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/ext -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/zend_abstract_interface -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/ext/vendor -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/ext/vendor/zai/hook -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/ext/vendor/mpack -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/ext/vendor/mt19937 -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/src/dogstatsd -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/ext/integrations  -DHAVE_CONFIG_H  -g -O2 -D_GNU_SOURCE -pthread -fvisibility=hidden  -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1 -Wall -std=gnu11 -DZEND_COMPILE_DL_EXT=1 -c /private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/ext/ip_extraction.c -o ext/ip_extraction.lo  -MMD -MF ext/ip_extraction.dep -MT ext/ip_extraction.lo
 clang -I. -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/include -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/main -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source -I/nix/store/547rl0b0d6hl9hwxj6dx8r06x8c99y9m-php-8.3.0alpha3-dev/include/php -I/nix/store/547rl0b0d6hl9hwxj6dx8r06x8c99y9m-php-8.3.0alpha3-dev/include/php/main -I/nix/store/547rl0b0d6hl9hwxj6dx8r06x8c99y9m-php-8.3.0alpha3-dev/include/php/TSRM -I/nix/store/547rl0b0d6hl9hwxj6dx8r06x8c99y9m-php-8.3.0alpha3-dev/include/php/Zend -I/nix/store/547rl0b0d6hl9hwxj6dx8r06x8c99y9m-php-8.3.0alpha3-dev/include/php/ext -I/nix/store/547rl0b0d6hl9hwxj6dx8r06x8c99y9m-php-8.3.0alpha3-dev/include/php/ext/date/lib -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/ext -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/zend_abstract_interface -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/ext/vendor -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/ext/vendor/zai/hook -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/ext/vendor/mpack -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/ext/vendor/mt19937 -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/src/dogstatsd -I/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/ext/integrations -DHAVE_CONFIG_H -g -O2 -D_GNU_SOURCE -pthread -fvisibility=hidden -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1 -Wall -std=gnu11 -DZEND_COMPILE_DL_EXT=1 -c /private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/ext/ip_extraction.c -MMD -MF ext/ip_extraction.dep -MT ext/ip_extraction.lo  -fno-common -DPIC -o ext/.libs/ip_extraction.o
/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/ext/ip_extraction.c:91:35: error: too few arguments provided to function-like macro invocation
    memcpy(out, ZEND_STRL("HTTP_"));
                                  ^
/nix/store/vw0zbvb4n6c1mwfj5x4ggngqlkfgb070-Libsystem-1238.60.2/include/secure/_string.h:64:9: note: macro 'memcpy' defined here
#define memcpy(dest, src, len)                                  \
        ^
/private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/ext/ip_extraction.c:91:5: warning: expression result unused [-Wunused-value]
    memcpy(out, ZEND_STRL("HTTP_"));
    ^~~~~~
1 warning and 1 error generated.
make: *** [Makefile:341: ext/ip_extraction.lo] Error 1
error: builder for '/nix/store/j1kizlrwlc01viyqbd7xwqr7pcq1hcjw-php-datadog_trace-0.89.0.drv' failed with exit code 2;
       last 10 log lines:
       >     memcpy(out, ZEND_STRL("HTTP_"));
       >                                   ^
       > /nix/store/vw0zbvb4n6c1mwfj5x4ggngqlkfgb070-Libsystem-1238.60.2/include/secure/_string.h:64:9: note: macro 'memcpy' defined here
       > #define memcpy(dest, src, len)                                  \
       >         ^
       > /private/tmp/nix-build-php-datadog_trace-0.89.0.drv-0/source/ext/ip_extraction.c:91:5: warning: expression result unused [-Wunused-value]
       >     memcpy(out, ZEND_STRL("HTTP_"));
       >     ^~~~~~
       > 1 warning and 1 error generated.
       > make: *** [Makefile:341: ext/ip_extraction.lo] Error 1
       For full logs, run 'nix log /nix/store/j1kizlrwlc01viyqbd7xwqr7pcq1hcjw-php-datadog_trace-0.89.0.drv'.

PHP version

8.1, 8.2

Tracer or profiler version

0.89.0

Installed extensions

No response

Output of phpinfo()

No response

Upgrading from

No response

[drupol]

Issue has been fixed, closing the issue.