Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry DataDog exporter is broken because of breaking change in this package. #2269

Closed
owais opened this issue Apr 3, 2021 · 8 comments

Comments

@owais
Copy link

owais commented Apr 3, 2021

This package introduced some breaking changes that caused OpenTelemetry Python's DataDog exporter to break as well. We've pinned ddtrace dependency to the last know working version to make things work again. Opening this issue to let maintainers here know about it so they can fix the Otel exporter as they see fit.

open-telemetry/opentelemetry-python-contrib#400

Thanks.

@Kyle-Verhoog
Copy link
Member

Thanks for the quick fix @owais! We'll look into fixing the exporter to remove the pin 🙂

@phillipuniverse
Copy link

@Kyle-Verhoog what's the status here? And @owais is there a list of what the breaking changes are? I am interested in attempting a fix.

I'm running into #1413 which is resolved by #2459 and only available in 0.50.0+ of ddtrace.

@phillipuniverse
Copy link

@Kyle-Verhoog @owais any update here?

@pj-datadog
Copy link

@phillipuniverse This feature is currently in beta. Can you please reach out to Datadog support if it doesn't work as you expect. Thank You

@phillipuniverse
Copy link

@pj-datadog I am a bit confused by your comment. What exactly is in beta and how would I test it to see if it behaves as I would expect?

OpenTelemetry still pins the version of ddtrace to 0.47.0. My original question was why, and I’m still not sure why.

What am I missing?

@pj-datadog
Copy link

Hi @phillipuniverse, pardon the ambiguity there. The OTel Datadog Python Span Exporter that this issue talks about is still in beta. We invite you to reach out to Datadog support, we can learn more about the issue you are facing and your intended use of the library. We might also have an alternate option for you to test/use for your use-case.

As for your original question, we are still in the process of building and validating this feature. Before we release anything for our users, we want to make sure we are able to provide best support to our users on all of their use-cases. Thank you for being a valued DataDog customer!

@phillipuniverse
Copy link

Based on open-telemetry/opentelemetry-python-contrib#932 (comment) and the exporter being deprecated this issue can likely be closed.

@github-actions github-actions bot removed the stale label Jul 7, 2022
@majorgreys
Copy link
Contributor

Thanks @phillipuniverse for following up here. As you point out, the exporter (which depended on this library) is deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants