asyncio context does not chain sub-tasks

[thehesiod]

while browsing the code I noticed in https://github.com/DataDog/dd-trace-py/blob/master/ddtrace/contrib/asyncio/provider.py#L34 where it's associating a context with the current task, note that when doing things like asyncio.gather it will create new tasks so you won't be able to retrieve the context for the sub-tasks. In our product I wrote a monkeypatch to the task constructor to ensure that sub-tasks get associated with their "parent" tasks.

[palazzem]

Thank you @thehesiod for notifying this use case! we'll plan updating our code so that asyncio.gather will have the proper Context instance when the task-switching is in place.

[thehesiod]

btw, working on this right now along with adding support for aiopg + aiobotocore, PR coming out soon

[palazzem]

It would be great if you can contribute on that! thank you a lot! About the monkey-patching, while it's our common approach for third-party libraries, we usually prefer not to touch Python internals unless it's safe and supported by the language. But we're happy to see your proposal and continue this discussion whenever the PR is out!

Thanks a lot!

[thehesiod]

ok, have a PR in progress: #248

[thehesiod]

ok, PR works, but having some issues setting up the test system

[palazzem]

Fixed in #260 and #297. Closing since it will be released in the next 0.9.0 version.