Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyramid crashes when 'include()' used with relative import paths #311

Closed
jimabramson opened this issue Jul 14, 2017 · 2 comments
Closed

pyramid crashes when 'include()' used with relative import paths #311

jimabramson opened this issue Jul 14, 2017 · 2 comments
Labels
bug
Milestone
0.9.2

Comments

@jimabramson
Copy link

jimabramson commented Jul 14, 2017 •
edited
Loading

We added ddtrace-run to our py3 + pyramid app which caused it to crash on startup with an AttributeError (module 'ddtrace.contrib.pyramid' has no attribute 'models').

The cause turned out to be a series of config.include() calls which were using relative import paths; under ddtrace, pyramid's path resolver was mapping .foo to ddtrace.contrib.pyramid.foo (i guess it changes what __main__ means?)

Switching to absolute paths fixed the issue.
@jimabramson jimabramson mentioned this issue Jul 17, 2017
Closed
@palazzem palazzem added the bug label Jul 19, 2017
@bmermet bmermet mentioned this issue Sep 4, 2017
Merged
@palazzem palazzem added this to the 0.9.2 milestone Sep 7, 2017
@palazzem
Copy link

palazzem commented Sep 7, 2017

@jimabramson this one has been merged #342 ; it should fix the problem.

Closing.

@palazzem palazzem closed this as completed Sep 7, 2017
@jimabramson
Copy link
Author

confirmed, issue no longer exists with 0.9.1+master2494 - thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.9.2
Development

No branches or pull requests
2 participants
@jimabramson @palazzem