Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boto3 patch method crashes while fetching AWS region #525

Closed
apolloFER opened this issue Jul 30, 2018 · 0 comments
Closed

boto3 patch method crashes while fetching AWS region #525

apolloFER opened this issue Jul 30, 2018 · 0 comments
Assignees
@Kyle-Verhoog
Labels
bug integrations
Milestone
0.13.0

Comments

@apolloFER
Copy link

The boto3 patch method of the ddtrace library expects the boto3 request to have the region parameter set.

Some of requests do not have it set (shared an example with Datadog engineers privately) so the patched function crashes on the following line:

dd-trace-py/ddtrace/contrib/boto/patch.py

Line 68 in 7a3d0f6

region = getattr(instance, "region")

@Kyle-Verhoog Kyle-Verhoog self-assigned this Aug 1, 2018
@Kyle-Verhoog Kyle-Verhoog mentioned this issue Aug 1, 2018
Merged
@palazzem palazzem added this to the 0.12.2 milestone Aug 6, 2018
@palazzem palazzem modified the milestones: 0.12.2, 0.13.0 Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kyle-Verhoog Kyle-Verhoog

Labels
bug integrations
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
3 participants
@palazzem @Kyle-Verhoog @apolloFER