Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLAlchemy: ConnectionEvents.dbapi_error() event is deprecated #841

Closed
ghost opened this issue Mar 11, 2019 · 1 comment
Closed

SQLAlchemy: ConnectionEvents.dbapi_error() event is deprecated #841

ghost opened this issue Mar 11, 2019 · 1 comment

Comments

@ghost
Copy link

ghost commented Mar 11, 2019

SQL alchemy integration listens to dbapi_error event. (found here https://github.com/DataDog/dd-trace-py/blob/master/ddtrace/contrib/sqlalchemy/engine.py#L70).

This event is deprecated sice sqlalchemy 0.9. Recently there is a warning:

sqlalchemy.exc.SADeprecationWarning: The ConnectionEvents.dbapi_error() event is deprecated and will be removed in a future release. Please refer to the ConnectionEvents.handle_error() event.
@RobertTownley RobertTownley mentioned this issue Mar 31, 2020
Merged
@Kyle-Verhoog
Copy link
Member

This should have been addressed with #1324. Feel free to re-open if you're still seeing the issue 🙂

This was referenced Nov 17, 2022
Closed
Open
@github-actions github-actions bot mentioned this issue Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Kyle-Verhoog