Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Components#teardown! NoMethodError #1023

Merged
merged 1 commit into from
May 5, 2020
Merged

Fix Components#teardown! NoMethodError #1023

merged 1 commit into from
May 5, 2020

Conversation

delner
Copy link
Contributor

@delner delner commented May 5, 2020

Fixes #1021

This line was collecting old Statsd instances and shutting them down if not in use on teardown!. Looks like somehow we were getting nil Statsd instances in for metrics, and this array did not compact them out, resulting in the function attempting to nil.close.

dd-trace-rb/lib/ddtrace/configuration/components.rb

Line 135 in 10592ce

old_statsd = [

Added a compact and test to address the issue.

@delner delner requested review from a team and marcotc May 5, 2020 15:29
@delner delner self-assigned this May 5, 2020
@delner delner added bug Involves a bug community Was opened by a community member labels May 5, 2020
@delner delner mentioned this pull request May 5, 2020
Closed
marcotc
marcotc approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@delner delner added the core Involves Datadog core libraries label May 5, 2020
@delner delner merged commit c8e2fa4 into master May 5, 2020
@delner delner deleted the fix/components_teardown_nil_stats branch May 5, 2020 16:02
@delner delner mentioned this pull request May 5, 2020
Closed
@marcotc marcotc added this to the 0.35.1 milestone May 5, 2020
@jonallured jonallured mentioned this pull request May 6, 2020
Merged
@delner delner linked an issue May 12, 2020 that may be closed by this pull request
v0.35.0: NoMethodError 'close' when running Rails migrations #1024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcotc marcotc marcotc approved these changes

Assignees

@delner delner

Labels
bug Involves a bug community Was opened by a community member core Involves Datadog core libraries
Projects
None yet
Milestone
0.35.1
Development

Successfully merging this pull request may close these issues.

v0.35.0: NoMethodError 'close' when running Rails migrations Failed to deploy after 0.35.0 upgrade
2 participants
@delner @marcotc