Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JRuby to local docker test environment #1027

Merged
merged 1 commit into from
May 6, 2020
Merged

Add JRuby to local docker test environment #1027

merged 1 commit into from
May 6, 2020

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented May 5, 2020

This PR adds a missing part of our support for JRuby: a local docker test environment.

We should not be able to:

$ docker-compose run --rm tracer-jruby-9.2
root@645db68092db:/app# ruby -v
jruby 9.2.11.1 (2.5.7) 2020-03-25 b1f55b1a40 OpenJDK 64-Bit Server VM 25.242-b08 on 1.8.0_242-b08 +jit [linux-x86_64]

@marcotc marcotc added core Involves Datadog core libraries feature Involves a product feature labels May 5, 2020
@marcotc marcotc added this to the 0.36.0 milestone May 5, 2020
@marcotc marcotc requested a review from a team May 5, 2020 20:48
@marcotc marcotc self-assigned this May 5, 2020
delner
delner approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@delner delner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcotc marcotc merged commit d2330df into master May 6, 2020
@marcotc marcotc deleted the feat/add-jruby-compose branch May 6, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delner delner delner approved these changes

Assignees

@marcotc marcotc

Labels
core Involves Datadog core libraries feature Involves a product feature
Projects
None yet
Milestone
0.36.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcotc @delner