Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky Workers::Async test #1031

Merged
merged 1 commit into from
May 7, 2020
Merged

Fix flaky Workers::Async test #1031

merged 1 commit into from
May 7, 2020

Conversation

delner
Copy link
Contributor

@delner delner commented May 7, 2020

Sometimes the specs assert on running? before the worker thread has a chance to reach a running state, causing the test to fail. This pull request adds a delay to give the thread a time to start.

@delner delner added the dev/testing Involves testing processes (e.g. RSpec) label May 7, 2020
@delner delner added this to the 0.36.0 milestone May 7, 2020
@delner delner requested review from marcotc and a team May 7, 2020 15:20
@delner delner self-assigned this May 7, 2020
@delner delner merged commit b223e01 into master May 7, 2020
@delner delner added this to Merged & awaiting release in Active work via automation May 7, 2020
@delner delner deleted the ci/async_spec_failure branch May 13, 2020 14:43
@delner delner moved this from Merged & awaiting release to Released in Active work Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcotc marcotc marcotc approved these changes

Assignees

@delner delner

Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
Active work
  
Released
Milestone
0.36.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@delner @marcotc