Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize tracer before concurrency test #1047

Merged
merged 2 commits into from
May 21, 2020

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented May 20, 2020

Our new JRuby test suite fails frequently while running test/concurrent_test.rb. This happens because the tracer is lazily initialized concurrently across many threads, which we currently do not support.

This PR ensures the tracer is properly initialized before the concurrency test runs.

@marcotc marcotc added the dev/ci Involves CircleCI, GitHub Actions, or GitLab label May 20, 2020
@marcotc marcotc requested a review from a team May 20, 2020 21:12
@marcotc marcotc self-assigned this May 20, 2020
@marcotc marcotc added the dev/testing Involves testing processes (e.g. RSpec) label May 20, 2020
@marcotc marcotc merged commit d8dd728 into master May 21, 2020
@marcotc marcotc deleted the ci/jruby-race-concurrent-test branch May 21, 2020 19:31
@marcotc marcotc added this to the 0.36.0 milestone May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/ci Involves CircleCI, GitHub Actions, or GitLab dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants