Allow Rails patching to occur if Railties are loaded #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
bug
delner
force-pushed
the
fix/rails_patching_with_railties
branch
2 times, most recently
from
f0da53b
to
248ecd7
Compare
marcotc
reviewed
May 26, 2020
delner
force-pushed
the
fix/rails_patching_with_railties
branch
from
248ecd7
to
e3c088c
Compare
delner
force-pushed
the
fix/rails_patching_with_railties
branch
from
e3c088c
to
ab253d7
Compare
|
@delner when can we expect a release on this ? |
|
Hi @bheemreddy181, it was released just now :) https://github.com/DataDog/dd-trace-rb/releases/tag/v0.36.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #993, when users run Rails applications without
gem 'rails'and opt to load gems manually, the Rails patcher aborts patching because it can't find the Rails version in the Rails gem.This had to do with some changes we made to add stricter version checks for integrations in 0.33.0. It was checking if
Gem.loaded_specs['rails']was loaded, and when it didn't find it, it would assume Rails wasn't present.This pull request changes this check to also see if
gem 'railties'are loaded, which are used in Rails applications, regardless of whethergem 'rails'is included or not. Ifrailtiesare present, it will attempt Rails patching.