Add retry_count tag to Sidekiq job traces #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the traces include sidekiq.job.retry which is just the configuration value for whether the job should be retried, or how many retries should be attempted. This adds the current retry count for each job.
marcotc
approved these changes
Jul 8, 2020
There was a problem hiding this comment.
Thank you so much for this work @elyalvarado.
I was looking into a way to test this change, but Sidekiq will only reach its retry logic when running a real Sidekiq daemon thread, fetching jobs from Redis.
This is very distinct from our current testing setup, which uses Sidekiq::Testing.
Overall, I think the value provided is worth merging this change despite testing limitations.
marcotc
added
community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the traces captured for Sidekiq jobs when using the sidekiq integration include
sidekiq.job.retrywhich is just the configuration value for whether the job should be retried, or how many retries should be attempted. This information doesn't add too much value, as it can be found on the code and rarely changes for any particular job.This PR adds the current retry count for each job, which is available as
retry_countin the job payload according to Sidekiq documentation. This information is useful for debugging and identifying traces of jobs that are being repeated.