test:Ensure worker thread waits for test assertion #1103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing
Datadog::Workers::Async::Thread#running?
, we could encounter a race condition where we start a background task but that task finishes before we can check the result of#running?
:dd-trace-rb/spec/ddtrace/workers/async_spec.rb
Lines 266 to 274 in 6e326cc
This happens because the task we schedule to run is empty, finishing very quickly.
This PR changes the background task to wait for some time, so we can assert on it. The thread won't hold our test suite back because we call
worker#terminal
, which forcefully terminates the thread.