Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD_SITE and DD_API_KEY configuration #1107

Merged
merged 2 commits into from
Jul 13, 2020

Conversation

delner
Copy link
Contributor

@delner delner commented Jul 11, 2020

This pull request adds DD_SITE and DD_API_KEY configuration settings, which can be set via either ENV or via Datadog.configure. These settings are used for submitting trace and profile data to Datadog.

@delner delner added core Involves Datadog core libraries feature Involves a product feature labels Jul 11, 2020
@delner delner requested review from marcotc, brettlangdon, andrewardito and a team July 11, 2020 00:00
@delner delner self-assigned this Jul 11, 2020
@delner delner added this to In progress in Profiling via automation Jul 11, 2020
@delner delner force-pushed the feature/site_and_api_key_configuration branch from 1b4fa69 to c573b21 Compare July 11, 2020 00:02
@delner delner moved this from In progress to Review in progress in Profiling Jul 11, 2020
@delner delner force-pushed the feature/site_and_api_key_configuration branch from c573b21 to b201d18 Compare July 11, 2020 00:05
@delner delner changed the base branch from feature/profiling to master July 11, 2020 00:06
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to document DD_SITE and DD_API_KEY at this point?

Profiling automation moved this from Review in progress to Reviewer approved Jul 13, 2020
@delner
Copy link
Contributor Author

delner commented Jul 13, 2020

Neither are currently in use (although they will be in the near future.) I think it'd be best to document and contextualize these when they are applied for some specific purpose, so they aren't used unnecessarily or improperly. Happy to hear suggestions about documentation on this if you have ideas.

@delner delner merged commit 0995e95 into master Jul 13, 2020
Profiling automation moved this from Reviewer approved to Done Jul 13, 2020
@delner delner deleted the feature/site_and_api_key_configuration branch July 13, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries feature Involves a product feature
Projects
No open projects
Profiling
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants